Delete Records in found set only deletes records in view?

[dtrimbur]

It seems that if one tries to delete a large number of records (i.e. greater than the 30 in the list view) dataface only deletes the 30 not all the records in the found set, but reports that it deleted all the records in the set! (if I set the list view to display 100 records then it deletes the 100)

ps using dataface 0.6.9rc1

[shannah]

Thanks for pointing this out.. looks like a bug... I'll take a look and have it corrected for the next release.

-Steve

[geller]

Hi Steve just following up on this one. This still appears to be happening in 6.12 (haven't upgraded yet) is it addressed in newer releases?

Cheers
Graham

[shannah]

Here is a fix for this. In the Dataface/DeleteForm.php file, look for the _buildDeleteQuery() method. You will see a section that looks like:

Code: Select all

$query['-limit'] = 9999;//isset($values['-limit']) ? $values['-limit'] : 1;
$query['-skip'] = 0;//isset($values['-skip']) ? $values['-skip'] : 0;


Change it to

Code: Select all

$query['-limit'] = 9999;         
$query['-skip'] = 0;


-Steve